Dave Miner wrote: > As promised, here's the review for updating the phase 0 DC for the flag > day from bug 681: > > 3429 Changes for bug 681 and friends need porting to phase 0 DC > http://defect.opensolaris.org/bz/show_bug.cgi?id=3429 > > Webrev: > http://cr.opensolaris.org/~dminer/slim_3429/ > > Thanks, > Dave > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Dave Your changes looks good to me and I'm OK with you pushing these changes. On a related issue: bootroot_configure and post_bootroot_pkg_image_mod could benefit from being more robust. For example input arguments could be validated, error handling could be added with trap... I'm thinking of the kind of cleanup I had done to usbgen in response to bug 1462 "usbgen could use some shell expert love" Clearly this could/should be addressed as a separate issue and not impact your push. Joe
