Hi William, in general the changes look good, I have only couple of nits - please see below. Also, could you please attach test procedures used when validating that new modifications work and no regressions were introduced ?
Thank you, Jan auto_td.c --------- om_write_partition_table(), om_write_vtoc() - it seems after those functions were changed, they don't carry out real target modifications - this happens in do_ti(). Could you please rename those functions as the current names are misleading - I might recommend something like om_prepare_partition_table(), om_prepare_vtoc() perform_slim_install.c ---------------------- It seems slim_set_slice_attrs() is no longer used. If this is the case, could you please completely remove that function from slim_util.c ? William Schumann wrote: > http://cr.opensolaris.org/~wmsch/bug-4233/ > http://defect.opensolaris.org/bz/show_bug.cgi?id=4233 > > Calling TI twice for slices and partitions was fixed by using a single > calling point for each in perform_slim_install.c for GUI and AI. > > The actual installation failure turned out to be due to a TI bug in > which mktemp(3c) was being called using a pointer to a constant text > string, which mktemp() was overwriting. On the second call to TI, the > constant text area wasn't valid (did not contain "X"s) and mktemp() failed. > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
