Who me paranoid? ;)
Good catch. So why didn't you catch this for the initial push? ;)
It sure doesn't make sense to me either. I'll make the changes and send
out another webrev.
Joe
Jean McCormack wrote:
> Joe,
>
> I just have 1 question. The following code is in several places in ict.c:
>
> uid = (uid_t)ICT_USER_UID;
> gid = (gid_t)ICT_USER_GID;
> if (uid != 0 && gid != 0) {
>
>
> If I look up ICT_USER_UID and ICT_USER_GID I see them as defined to 101
> and 10.
> So why the check? Is it just for paranoia in case someone changes the
> #defs?
>
> The code looks good.
>
> Jean
>
>
> Joseph J VLcek wrote:
>> Hello,
>>
>> Can two people please do a code review for the fix for bug:
>>
>> 4108 The .profile file is missing in the default user's directory
>> after installation
>>
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4108
>>
>> The webrev is available at:
>> http://cr.opensolaris.org/~joev/bug4108/
>>
>>
>> * The modules affected and tested:
>>
>> libict
>>
>> * Testing done for GUI Install
>>
>> David Comay provided an IPS repo which contains the correct .profile
>> and .bashrc files in /etc/skel.
>>
>> I built an image using that repo.
>>
>> I rebooted the live Image and applied the updated libict library using
>> LD_LIBRARY_PATH
>>
>> * Results:
>>
>> I ran a full install and confirmed the correct .bashrc and .profile
>> files were available in the user's home directory with the correct
>> owner and file access permissions set.
>>
>> * Testing done for AI
>>
>> No AI testing was performed, which was approved by Dave Miner.
>>
>>
>> Thank you,
>> Joe
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
