Joe, I have taken a look at updated webrev and it looks good to me.
Thanks ! Jan Joseph J VLcek wrote: > Thank you Dambi! > > I've made the suggested changes from you and Karen, reran the tests > and posted an updated webrev available at: > > http://cr.opensolaris.org/~joev/bug4871_B/ > > Let me know if you feel I can push. > > Thanks, Joe > > jan damborsky wrote: >> Hi Joe, >> >> I have only two nits: >> >> [1] webrev comment is incorrect >> >> 4871 Grub text only mode is required >> -> >> 4871 ICT failures are not reported as a failed installation > > Yup... I had just noticed that myself... Doh! > >> >> >> [2]* please change permissions for install-finish, so that webrev >> doesn't generate warning for this >> >> 755 >> -> >> 644 > > OK I will fix this. > >> >> Other than that, those changes look good to me. >> Thank you, >> Jan >> >> >> Joseph J VLcek wrote: >>> Hello, >>> >>> Can two people please do a code review for a fix for bug: >>> >>> 4871 ICT failures are not reported as a failed installation >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4871 >>> >>> >>> The webrev is available at: >>> http://cr.opensolaris.org/~joev/bug4871/ >>> >>> >>> * The modules affected and tested: >>> >>> liborchestrator >>> install-finish >>> >>> * Testing done for GUI Install >>> >>> I booted a 101 live Image and applied the updated library using >>> LD_LIBRARY_PATH, I copied the updated install-finish script onto /sbin >>> >>> I fabricated a failure in ict.py with a hard coded error to have one >>> of the ICT return a failure. >>> >>> I used mount -F lofs so the ict.py containing the error would be used. >>> >>> I then repeated the test using the version of ict.py we deliver to >>> ensure the installation succeeded. >>> >>> * Results: >>> >>> When using the version of ict.py with a hard coded error the >>> installation reported errors. >>> >>> When using the version of ict.py we deliver, without a hard coded >>> error, the installation succeeded. >>> >>> >>> * Testing done for AI >>> >>> No AI testing was performed. >>> >>> >>> Thank you, >>> Joe >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
