Thank you Dave and Karen for the review feedback. I've applied the review feedback and retested.
An updated webrev is available at: http://cr.opensolaris.org/~joev/bug4673_B/ Please let me know if it looks OK to push. Thanks, Joe Joseph J VLcek wrote: > Hello, > > Can two people please do a code review for bug: > > 4673 Grub text only mode is required > http://defect.opensolaris.org/bz/show_bug.cgi?id=4673 > > > The webrev is available at: > http://cr.opensolaris.org/~joev/bug4673/ > > This fix involves a rewrite of ICT enable_happy_face_boot > > I also fixed some begin and end comment block issues that were causing > vim to display some of the code in the color of a comment. > > * The modules affected and tested: > > ict.py > > * Testing done on logic > > I wrote a stand alone wrapper around the changes so they could be > exercised outside of an installation environment. > > I tested: > > - a menu.lst file with multiple entries > - a menu.lst file with a single entry > - a menu.lst file with embedded comments > - a non-existing menu.lst file, reports an error > - a read only menu.lst files, reports an error > > * Testing done for GUI Install > > I booted a 101 live Image and used mount -F lofs to applied the updated > version of ict.py > > After the installation I performed reboots selecting the default before > the timeout, I let the timeout select the default and I selected the > text boot entry > > * Results: > > The installation completed successfully and the menu.lst file contained > the default graphical boot entry and a second, text boot entry and both > entries provide the expected behavior. > > * Testing done for AI > > No AI testing was performed. > > > Thank you, > Joe > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
