Thanks Jack. I looked at the updated webrev. Everything looks good to me now.
--Karen Jack Schwartz wrote: > Hi Karen. > > Thanks for reviewing. Please see below. > > On 11/14/08 15:22, Karen Tung wrote: >> Jack Schwartz wrote: >>> Wow! How cool is that? Thanks, Dave! >>> >>> I've basically taken this, and indented the code between the >>> single-quotes. >>> >>> I tested doing a build, and also verified via a test script that the >>> Hard Disk entry (entries) get removed wherever they are in the menu. >>> >>> Webrev updated at the same location: >>> >>> http://cr.opensolaris.org/~schwartz/081112.1/webrev/ >>> >>> On the caiman-discuss IRC channel, Dave has already approved this >>> change, so I need only one more reviewer. >>> >>> Thanks, >>> Jack >>> >>> >> Hi Jack, >> >> I think we should check the return value of nawk. What if it fails, >> we don't want to >> just overwrite the file. Everything else is fine. > OK. I've revised the webrev. Now, if nawk fails, it prints a warning > but continues with the original Hard Disk entry left in. I didn't > think a nawk error here was worthy of trashing the whole usb image. > > Webrev is in the same place. > > I've tested error case (simulated by a bad file passed to nawk), a > good case, and a case where there was no Hard Disk entry in menu.lst. > > Thanks, > Jack >> >> Thanks, >> >> --Karen >
