Sanjay,
I implemented your suggestion.
William
sanjay nadkarni (Laptop) wrote:
> William Schumann wrote:
>> Sanjay,
>>
>> sanjay nadkarni (Laptop) wrote:
>>> William Schumann wrote:
>>>> http://cr.opensolaris.org/~wmsch/bug-3233/
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3233
>>>>
>>>> Space used for snapshots was being handled in an int, where it
>>>> should have been handled in a 64-bit unsigned variable.
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>
>>> Minor nit. It looks like you have added a blank line (915). I
>>> would instead prefer to see a blank line after declaration of
>>> uint64_t i.e. between 912 and 913.
>>>
>> I placed the blank line after the function declarations in the
>> function according to Sun coding standards. Line 913 contains a
>> declaration:
>>
>> 912 uint64_t space_used;
>> 913 zfs_handle_t *zfshp = zfs_open(g_zfs,
>> ds_path,
>> 914 ZFS_TYPE_SNAPSHOT);
> Yup..sorry I missed the function declaration. Any reason why not to:
>
> zfs_hangle_t *zfshp;
>
> zfshp = zfs_open(.....)
>
> The complier will still do the same thing however this will improve
> readability.
>
>
> -Sanjay
>
>>
>> William
>
