Sundar Yamunachari wrote:
> William Schumann wrote:
>> Sundar Yamunachari wrote:
>>> Hi,
>>>
>>> I need two reviewers for the following change.
>>>
>>> - The callbacks sent to GUI indicate installation is completed
>>> before post-install tasks are completed. This may result in an
>>> incomplete installation. The change here is to send the installation
>>> complete callback notification only after post-install tasks are
>>> completed.
>>>
>>> http://installzone.sfbay.sun.com/si-iteam/webrev/2007_10/slim_install_sundar_1024/
>>>
>>>
>>>
>> Sundar,
>> Won't the OM_POSTINSTAL_TASKS milestone be called more than once -
>> for each tick of the indicator? Here, it looks as if the first time
>> the OM_POSTINSTAL_TASKS milestone is called, the installation will be
>> terminated. Doesn't it?
> William,
>
> Thanks for the review. The postinstall milestone currently called
> only once to indicate that the install is complete. This is the case
> for dwarf caiman installed too. This may become a separate module with
> own callbacks in the future. Right now there is only one
> OM_POSTINSTAL_TASKS milestone callback.
>
> - Sundar
>
Sundar,
Then it looks fine to me.
William
>> william
>>> Thanks,
>>> Sundar
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>
>
