Dave Miner wrote: > Karen Tung wrote: >> This code review fixed 2 things: >> >> 1) After the removal of the previous slimcd_post_processing.tar and >> moving >> code around. The mkrepo script can no longer read the >> generic_live.xml file >> because it can't find it in "./". The full path to the >> generic_live.xml file >> need to be passed into mkrepo. >> >> 2) When some of the gnome postinstall scripts fail, all the output are >> re-directed to /dev/null. This makes debugging the failures difficult. >> Change it to redirect output from postinstall scripts to a file. If the >> script failed, content of that file will be displayed. >> > > Generally I'd suggest the temporary output redirection go to something > like /tmp/postrun.output.$$ so you're not dependent on write access to > the current directory. Also, sending the error output you're cat'ing > at 19 in exec_postrun to stderr would allow for whatever's calling it > to more easily discern it as error output. > > Dave Hi Dave,
Thanks for the code review. In general, I would agree with the opinion that the outputs should go to /tmp. I can still do that in this case, but we really don't need to worry about write access in this case since the directory in which the scripts are run is created by the Distro Constructor, so, we are guaranteed to have write access. The output I am "cating" is not error output. Those are outputs from running post_install scripts. Regardless success or failure of those scripts, I found that tons of outputs are produced. In the case where running the script is successful, I don't really see a point of displaying the output of the script. In the case that the script failed, I thought displaying the output will be able to help people with debugging the failure. --Karen
