David.Comay at Sun.COM wrote:
>> And please review the webrev at:
>>
>> http://cr.opensolaris.org/~dminer/slim_prototype/
>>
>> which addresses the below issues with licensing as well as fixes the
>> empty grub menu on the installed system and failure of the installer's
>> Reboot button to initiate an actual reboot.
> 
> Looks good.  A few comments
> 
> slim_prototype/packages/utils/profile
> 
>     I wonder whether it makes sense to add /usr/gnu/bin to the
>     front of the path for "jack"?
> 

I'll add it, I think it would be safer in terms of stabilizing at this 
point to put it at the end than front, though.

> slim_prototype/packages/utils/prototype
> 
>     While using earlier versions of the Live CD and also on a newly
>     installed system, I noticed that the user was missing the
>     "Documents" folder and some tools complained about it (for
>     example, being up the Appearance system preference or whatever
>     is called caused an error about a missing "Documents" folder).
> 

Easy to add, done.

Dave

Reply via email to