Jan Damborsky wrote:
> Hi Joe,
>
> could I please ask you to review the fix for following bug ?
>
> 5271 Serial console setting should be carried through to installed system
>
> I am soliciting your feedback, since changes were done
> in ICT code - the area you are familiar with :-)
>
> * Webrev:
> http://cr.opensolaris.org/~dambi/bug-5271
>
> Thank you very much,
> Jan
>
> Modules affected and tested:
> * ICT - ict.py
>
> tests carried out:
> * created x86 AI image based on build 119
>
> testing the fix
> * AI installation done on x4100 via serial console
> - 'console=ttya' added to GRUB menu
> - on installed system:
> - GRUB menu didn't contain GRUB splash image
> - happy face boot was disabled
> - /boot/solaris/bootenv.rc file contained correct
> propagate 'console' property set to 'ttya'
>
> regression test
> * AI installation done on W2110z using local graphic monitor+keyboard
> - on installed system:
> - GRUB menu contained GRUB splash image
> - happy face boot was enabled
> - /boot/solaris/bootenv.rc file contained correct
> 'console' property set to 'text'
>
Issue:
---------
I don't think the 'timeout 30' is needed in the GRUB menu if the
splashimage is not added.
Have you investigated that it is?
If I am correct and the 'timeout 30' is only needed when splashimage is
added then the logic being added at line 869 and 872->874 could be
outside of the try block. As you've done in enable_happy_face_boot.
I think the logic could be:
...
if self._get_osconsole() == 'text':
info_msg('Console on serial line, GRUB splash image will be disabled')
return 0
grubmenu = self.GRUBMENU
try:
...
Other than this one issue the changes look good.
Joe
