Ethan Quach wrote:
> Need a code review ....
>
> Webrev:
> ------------
> http://cr.opensolaris.org/~equach/webrev.10575
why not simplify this a bit by doing the following:
if ((tok = strtok(temp_line, BE_WHITE_SPACE)) != NULL &&
strcmp(tok, "default") == 0) {
Other than that it looks fine.
-evan
>
> Defect:
> ----------
> http://defect.opensolaris.org/bz/show_bug.cgi?id=10575
>
>
> Tested this by using the latest bits to activate BEs
> when the menu.lst file does, and does not, have empty
> lines in it. Made sure core dump no longer occurs, and
> also made sure the any existing empty lines are carried
> over to the modified menu.lst file.
>
>
> thanks,
> -ethan
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
