Hi Matt, The patch looks good to me.
Regards, Jedy On Tue, 2009-08-11 at 14:10 +0100, Matt Keenan wrote: > CR request for bug : > http://defect.opensolaris.org/bz/show_bug.cgi?id=1290 > Malformed "Adusted partition..." dialog > > Webrev : > http://cr.opensolaris.org/~mattman/bug-1290/ > > Turns out two issues here. > > - the original dialog was actually an Error dialog, only a close button > available to the user, should have been a warning dialog with OK/Cancel as > the message indicated. > - Second issue to change the dialog text. > > In this section of code there are two other possible Errors being detected > and the user should not be able to continue installation in these scenarios. > > Solution : > - Change text for warning dialog to new text. > - Correctly display warning dialog with OK/Cancel buttons > - Ensure error dialog is being displayed for other two scenarios. > > cheers > > Matt > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
