Hi Harshal, Harshal wrote: > Hi, > > Could I get the code review for the patch which will enable to do non > default installation? This patch removes caiman's dependency on > firefox to be present in package list. This way one can install > minimal possible install of Opensolaris using Caiman. > > The bug can be viewed at, > > http://defect.opensolaris.org/bz/show_bug.cgi?id=5558 > > I have attached the patch file with this email. > > We depend on this patch heavily as we plan to use Caiman. Please let > me know how to get this patch into next release of Caiman.
In general, there are couple of steps involved one needs to go through in order to integrate into source gate - please see following page for the procedure: http://www.opensolaris.org/os/project/caiman/Developers/ Speaking about code review process, the changes/patch should be presented in form of so-called 'webrev' and published on cr.opensolaris.org page - following document provides 'how to': http://cr.opensolaris.org/ When sending request for code review, please also attach the list of test procedures (along with results) which were carried out in order to make sure that the modification * fixes the problem AND * doesn't break existing functionality Please feel free to ask if not sure about anything, as it might be challenging to absorb and understand all that stuff when doing this for the first time. You can either ask on this mailing alias or use publicly available #caiman-discuss IRC channel. Hope this might help :-) Jan
