Virginia Wray wrote: > Hi Dave - > > Thanks. I appreciate the feedback. I don't mind fixing the other stuff > at all. When I looked at it to > figure out the correct why to change it, it was really confusing, so I > totally understand why > it's not a good practice. > > If you wouldn't mind one more look to see if I've addressed the > outstanding issue: > http://cr.opensolaris.org/~ginnie/4279-3/ >
Changes are fine. One exceedingly tiny stylistic nit is the extra use of braces at 182 and 186 in td_mountall.c; it's not wrong per se, just inconsistent with the lines immediately preceding it, and consistency of style is one of the principles of the style guide. No need for re-review if you do decide to accept this change. Dave
