Hi Matt.
Makefiles look alright to me.
I have some suggestions/questions about callbacks.c though...
1) Code at 796 - 809 can be optimized:
if (be_list(NULL, &be_nodes) == 0) {
...
}
execl (command_path, REBOOT, NULL)
no need for 805-807
2) I'm suspicious of 802. Should this be be_cur->be_root_ds instead of
be_nodes->be_root_ds?
Did you test with systems with multiple BE's where the active BE was not
the last BE in the list?
Thanks,
Jack
On 08/31/09 09:12, Matt Keenan wrote:
> Bug :
> http://defect.opensolaris.org/bz/show_bug.cgi?id=9471
> Installer should at least try to do a fast-reboot after install
>
> Webrev :
> http://cr.opensolaris.org/~mattman/bug-9471/
>
>
> Currently installer simply calls "reboot" when a user has completed
> installation. The bug suggests the an attempt be made to do a fast
> reboot (-f path) by default.
>
> To achieve this libbe can be used to get a list of BE's available
> and from this list the BE which has be_active_on_reboot set on is used
> as argument to reboot -f.
>
> If no be_active_on_reboot BE is found or be_list fails then normal
> reboot will be performed.
>
> Testing:
> - Local testing
> - ISO built via Distro Constructor and installed via VirtualBox VM.
>
> cheers
>
> Matt
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
