Hi Jan,
> My apologies - I was probably looking at the old webrev.
> Looking at the latest one, I meant to refer to the following code:
>
> 195 if [ -z "${MAC_ADDR}" -o -z "${SERVICE_NAME}" ]; then
> 196 echo "${myname}: Missing one or more required options."
> 197 usage
> 198 fi
>
> [...]
>
> 256 if [ "X${MAC_ADDR}" != "X" ] ; then
>
> Since MAC_ADDR is mandatory, it can't be empty -
> I think check on line 256 is redundant.
Oh, you were talking about MAC_ADDR. Yes, I agree with this, and I'll
remove 256.
> As far as code related to 'IMAGE_PATH' is concerned,
> I agree with you - since it is not mandatory, it would
> be empty when not provided by the user and the check on
> line 227 is required.
Actually, it is mandatory. It was changed to be mandatory after this
code was written, so it is good you mentioned it. After looking at the
code more closely, I have changed the parsing, changed 195 to look like
this:
if [ -z "${MAC_ADDR}" -o -z "${IMAGE_PATH}" -o -z "${SERVICE_NAME}" ]; then
and removed line 227 which was:
if [ -n "${IMAGE_PATH}" ]; then
Please refer to the new webrev when Sundar sends it out.
Thanks,
Sue
