Ethan Quach wrote: > > > Evan Layton wrote: >>>>> cleanup: I believe a close(fd) should be there. >>>>> >>>> what line? >>>> >>> Sorry. Somewhere in the cleanup that starts at 2664. >>> >>> Jean >>> >> >> OK I run through that again and see if I can find what appears to be >> missing. >> > > Its not needed in cleanup: there's a close(fd) call at line 2558 if the > fdopen() failed. Beyond that, calling fclose(tfile) would close fd, and > that fclose is in cleanup: > OK. Sorry. End of a long review.
Jean > > -ethan >
