Requesting a 1-line code review:
http://defect.opensolaris.org/bz/show_bug.cgi?id=3793
http://cr.opensolaris.org/~wmsch/bug-3793/
if /a/etc/dumpadm.conf is missing, it causes a traceback during
update_dumpadm_nodename ICT.
Traceback (most recent call last):
File "/sbin/install-finish", line 133, in ?
sa.append(icto.update_dumpadm_nodename())
File "/usr/lib/python2.4/vendor-packages/osol_install/ict.py", line
827, in
update_dumpadm_nodename
if not _move_in_updated_config_file(newdumpadmfile, dumpadmfile):
File "/usr/lib/python2.4/vendor-packages/osol_install/ict.py", line
177, in
_move_in_updated_config_file
if filecmp.cmp(new, orig): #if files are identical
File "/usr/lib/python2.4/filecmp.py", line 49, in cmp
s2 = _sig(os.stat(f2))
OSError: [Errno 2] No such file or directory: '/a/etc/dumpadm.conf'
close failed: [Errno 2] No such file or directory
In a function that compares original configuration files with edited
ones, if
the original file is not present, a traceback will occur on:
if filecmp.cmp(new, orig): #if files are identical
Fix checks for existence of new and original files before making the
comparison.
