Hi Harold, the changes look good to me.
I have only one generic comment - I can see that the code switches to the new feature without checking if it is available and selecting the old path if it is not. I think this is fine, if we don't plan to backpublish this stuff into builds <99. However, as I am not sure what the plans are with respect to this, we might need to clarify. Thank you, Jan Harold Shaw wrote: > This is a code review for the following bugs: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=3396 > http://defect.opensolaris.org/bz/show_bug.cgi?id=3663 > > This provides support for VTOC/fdisk on disks up to 2 TB. The webrev is > located at http://cr.opensolaris.org/~hshaw/slim_3396_3663/ > > Thanks, > Harold > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
