Tim Knitter wrote: > Ethan, > > Nit: > 1980 method -> function since the zfs_name_valid() is a C function. Or better > yet just remove "method" since the function name, zfs_name_valid(), already > implies a function. e.g. The '%' is invalid, but zfs_name_valid() allows ... >
Done, and webrev updated. thanks, -ethan > Thanks > Tim > > Ethan Quach wrote: > >> This one is pretty simple and straight forward. >> We are adding an additional check to make sure >> the boot environment name does not contain a '%' >> >> >> Webrev: >> ------------- >> http://cr.opensolaris.org/~equach/webrev.3769 >> >> >> Defect: >> ----------- >> 3769 more boot environment name validation. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3769 >> >> >> thanks, >> -ethan >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
