Jan,

The code changes look fine except the following

*usr/src/cmd/auto-install/svc/auto-installer:*

150: When we inform the user that Automated Installer started, we also 
need to tell the user how to find the status of the install. You can add 
a line something similar to "The progress of the automated installation 
can be followed by viewing the logfile at /tmp/install_log"

Thanks,
Sundar

jan damborsky wrote:
> Hi all,
>
> could I please ask one more pair of eyes to take a look
> at the webrev ?
> The changes are mostly about cleaning up auto-installer SMF
> service manifest and displaying start/finish success/failure
> messages for AI installation.
> However, those changes should be pushed into the gate today,
> since they also addresses problem when installer is automatically
> restarted after successful installation (bug 4119).
>
> Thank you very much,
> Jan
>
>
> jan damborsky wrote:
>   
>> Hi,
>>
>> please, can two people review the fix for following AI bugs ?
>>
>> 4029 auto-install should log install start/finish to the console
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4029
>>
>> 4084 auto-installer.xml SMF manifest needs to be cleaned up and completed
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4084
>>
>> 4119 auto-installer service is restarted after successful installation
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4119
>>
>> The webrev is available at:
>> http://cr.opensolaris.org/~dambi/bug-4029_4084_4119/
>>
>> Thank you,
>> Jan
>>
>>
>> Modules affected:
>> -----------------
>> * AI SMF service
>>
>> Testing done:
>> -------------
>> AI image based on build 100a built
>> * message displayed on console before AI started
>> * message displayed on console after AI finished
>> * auto-installer start method was not restarted -
>>   service went into 'online' state
>> * installation finished successfully
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>     
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20081023/c351ab17/attachment.html>

Reply via email to