Hey Evan,
> Hi Tim, > > A couple of questions... > > Why are we getting rid of BEADM_ERR_BENAME_SNAPSHOT and > BEADM_ERR_ACTIVATE_OPTS in messages.py? Were lines 233 to 235 the only Tried to elaborate on that with the text below. If you need more info please let me know. > place BEADM_ERR_BENAME_SNAPSHOT was used? Yes, they're not used in any other places. > > It also looks like we're only doing this check for activate and destroy. > Why don't we check for the correct number of arguments for the rest of > the subcommands? The other subcommands already work correctly wrt the number of args being passed in. Thanks Tim > > -evan > > Tim Knitter wrote: >> Hello, >> >> Can I get a review for this easy fix: >> >> WR: http://cr.opensolaris.org/~tsk/2628/ >> D: http://defect.opensolaris.org/bz/show_bug.cgi?id=2628 >> >> I also removed unneeded messages for both 'beadm activate' and 'beadm >> destroy' since printing the usage when a command line user error >> occurs, displays the info the user needs anyway. >> >> Thanks >> Tim >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
