Ethan Quach wrote: > Evan, > > be_utils.c > > 588 - Doesn't seem like you need to check found_default here. You > wouldn't be here unless it was True because of the check on 577.
true, don't need it. > > 590,594 - Does this assume that the bootfs line is always the next > line under title? If so, needs to be fixed. It shouldn't matter what order they're in after the title line, if there are lines between the title and the bootfs line they will be skipped. If we hit another title before we find a bootfs line we know that the last entry didn't have a bootfs line. At this point we're dealing with a new entry so we increment the counter and check this entry. -evan > > > -ethan > > > Evan Layton wrote: >> I need a review of >> >> http://cr.opensolaris.org/~evanl/snap_945/ >> >> which addresses >> >> 945 libbe: be_list needs better active on reboot checking >> http://defect.opensolaris.org/bz/show_bug.cgi?id=945 >> >> Thanks! >> -evan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
