Hi Niall, the changes look good to me.
Thank you, Jan Niall Power wrote: > Hi, > > requesting code review for bug 968 : Minimum disk size is smaller than it > should be > http://defect.opensolaris.org/bz/show_bug.cgi?id=968 > > Webrev of changes at: > http://cr.opensolaris.org/~niall/bug-968 > > The approach to the fix is to round the minimum installation size > representation in GB to 1GB and to ensure that rounding is always > upwards instead of downwards by correcting the rounding results > if necessary. The rounding up has been made an optional parameter > to orchestrator_om_get_mininstall_sizegb(). For internal calculations > the API is used without the rounding flag set for better accuracy. > > The confirmation screen no longer hardcodes a minimum size and > instead uses the appropriate orchestrator API to determine this value. > > Also, since there is now an API available to determine the recommended > installation size, I have added the prototype to orchestrator_api.h and > defined two new APIs for the GUI to use it in orchestrator-wrappers.[ch] > > Thanks, > Niall. > -- > This message posted from opensolaris.org > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
