Ethan, the fix looks good to me.
Thank you, Jan Ethan Quach wrote: > Jan, > > Yes, I can use 'mv' instead. > > One minor thing I want to change though is to be more explicit in the > pattern match. > I'd like for it to match "-B $ZFS-BOOTFS" instead. > > This has been retested along with the 'mv' change. Can you take another > look. > > > thanks, > -ethan > > > jan damborsky wrote: > >> Hi Ethan, >> >> I have only one nit: >> >> Would it be ok to use 'mv' instead of 'cat + cp' ? >> >> Other than that the fix looks fine. >> >> Thank you, >> Jan >> >> >> >> Ethan Quach wrote: >> >> >>> Can I get a review of >>> >>> Defect: >>> -------- >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=985 >>> >>> Webrev: >>> --------- >>> http://cr.opensolaris.org/~equach/webrev.985 >>> >>> >>> thanks, >>> -ethan >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> >>> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
