Moinak Ghosh wrote: > Hi Folks, > > Requesting review of the following small fix: > > [Bug 998] New: installer hangs at Fixing zero-length files... > http://defect.opensolaris.org/bz/show_bug.cgi?id=998 > > Webrev: > http://cr.opensolaris.org/~moinakg/tm_python/ > > The fix calls unlink on all zero length files while ignoring > errors from unlink. This ensures that symbolic links to zero > length files are removed before the file is created. >
The fix is OK. I wonder, though, if we should be filtering zero-length files out of the list of links created during the construction process. Other than the gimlet files, I get the following list: ./etc/dfs/sharetab ./etc/dumpdates ./etc/mail/local-host-names ./etc/mnttab ./etc/security/dev/audio ./etc/security/dev/fd0 ./etc/security/dev/sr0 ./etc/security/dev/st0 ./etc/security/dev/st1 ./var/adm/aculog ./var/adm/spellhist ./var/adm/utmpx ./var/adm/wtmpx ./var/log/authlog ./var/log/postrun.log ./var/log/syslog ./var/saf/zsmon/log These all seem like things that probably ought to be writable on the CD. Dave
