Roland Mainz wrote: > jan damborsky wrote: >> Roland Mainz wrote: >>> jan damborsky wrote: >>>> William James wrote: >>>>> On Tue, Apr 8, 2008 at 4:30 AM, Dave Miner <Dave.Miner at sun.com> wrote: >>>>>> Jan Damborsky wrote: > [snip] >>>> I chose the bash due to the time constraints - >>>> at that point I was more familiar with bash than >>>> ksh93. >>> To end this debate - attached is a ksh93 version of the script. I did >>> some minor changes in functionality, e.g. ... > [snip] >>> The script is attached as "set_lang.ksh" ... >> thank you very much for your time and coming >> with the proposal. > > No problem... > >> Since the original fix already went through >> the code review process and was already integrated, >> I think you would need to file new bug, > > ... see http://defect.opensolaris.org/bz/show_bug.cgi?id=1060 > ('Alternative script for language selction ("set_lang.ksh")')
Thank you for filing the bug. Since you assigned me to this issue, let me clarify, how I plan to proceed with triaging/fixing the bug. I believe for now that the fix for 973 in the form it was integrated will disappear for next release. From my point of view, there wouldn't be any added value resolving this bug by simply replacing the bash script with ksh version. As things are evolving pretty quickly, I can see I might take different approach in near or longer future. For example, if for some reason it would turn out that the fix for 973 is not sufficient solution for May release and this issue would be marked as critical (as we are now officially in the stabilization phase for May release, only critical issues are allowed to be integrated) then I can see no reason, why not to get rid of bash version (considered from beginning as temporary) and proceed with other implementation. The one way might be to take your proposal as starting point for improved solution. Or if it turns out that more design changes would be necessary, my plan B is to implement it in Python language. I would also apply similar decision making process, if we are going to address this issue for next release. Please let me know, if it might make sense to you. > >> if you >> would like to integrate your changes into the gate. > > Technically I only wrote the patch to end the bickering (since I > sometimes wish people would write more code and do less bickering) Yeah...agreed ;-) I really appreciate your help in this point - thank you. Jan
