Hi Jedy, The changes look good to me.
Thanks, Niall. Jedy Wang wrote: > Hi all, > > The patch is updated. New webrev of changes is at: > http://cr.opensolaris.org/~jedy/bug-1074-new > <http://cr.opensolaris.org/%7Ejedy/bug-1075-new> > > The patch includes the changes to date-time-zone.glade which is to > remove the vertical scorllbar in date time screen. Because some unused > widgets, such as timezonealign, are removed, datetimezone-screen.[ch] > are updated accordingly. > > This patch also fixes a problem in the original patch. The old patch > can not handle resized window. If the window is large enough and white > margin is added to the left/right side of the map, the map is still > scrolled to wrong place. New patch fixed this problem. > > If you want to have a try. You can find the latest binary of > gui-install at /net/fulltime.prc/export/home/share/gui-install.tar.gz. > 1) gtar zxvf gui-install.tar.gz > 2) cp gui-install /usr/share/ > 3) run /usr/share/bin/gui-install > > Regards, > > Jedy > > On Thu, 2008-04-10 at 06:00 +0000, Jedy Wang wrote: >> Hi, >> >> requesting code review for bug 1074: the point under the mouse should >> remain the same when zooming in/out >> http://defect.opensolaris.org/bz/show_bug.cgi?id=1074 >> >> Webrev of changes is at: >> http://cr.opensolaris.org/~jedy/bug-1074/ >> <http://cr.opensolaris.org/%7Ejedy/bug-1074/> >> >> Overview >> *usr/src/cmd/gui-install/src/map.c* >> Add new interface: map_update_offset_with_scale and remove >> map_center_at_timezone. >> >> *usr/src/cmd/gui-install/src/timezone.c* >> Add calls to map_update_offset_with_scale. >> >> Regards, >> >> Jedy >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org <mailto:caiman-discuss at opensolaris.org> >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
