William Schumann wrote:
> Ethan,
> I edited messages.py to supply a default of 'n' and added it to the
> webrev. I cleaned up a little along the way.
> William
>
Looks OK.
Dave
> Ethan Quach wrote:
>>
>> William Schumann wrote:
>>> Ethan,
>>>
>>> Ethan Quach wrote:
>>>> William,
>>>>
>>>> beadm.py
>>>> ------------
>>>> 1280 - if len(value) == 0, can we make it do the
>>>> msg.msgs("errInvalidResponse")
>>>> instead?
>>> The len(value) == 0 represents the default. Do you want to make the
>>> user type 'y' or 'n'?
>> If simply hitting enter does the default action, then the presented
>> prompt should be more clear on the fact that there is a default.
>> For example:
>>
>> This is the question (y|n) [n]:
>>
>> or something like that.
>>
>>
>>> As per our offline discussion, ludelete does not prompt for deletion
>>> of an BE.
>>> Any prompting here must be eventually localized.
>> Thanks, this is good to know.
>>
>>
>> -ethan
>>
>>> William
>>>> Otherwise, looks okay.
>>>>
>>>> thanks,
>>>> -ethan
>>>>
>>>>
>>>> William Schumann wrote:
>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1232
>>>>> Description: When prompted for a y|n answer to confirm a destroy of
>>>>> a BE, beadm will fail with a traceback if a carriage return is entered
>>>>> with no input
>>>>> http://cr.opensolaris.org/~wmsch/bug-1232/
>>>>>
>>>>> The traceback was caused by attempting to read the first character
>>>>> of a zero-length string.
>>>>>
>>>>> Also, the function to handle user input was not acting on a
>>>>> negative user response to the destroy question (y/n). Added a
>>>>> check for the user answering 'n'. No user input is now treated as a
>>>>> 'n'. Changed code so that 'yes' and 'no' are also acceptable
>>>>> responses.
>>>>>
>>>>> Added an exception handler for a keyboard interrupt to stop a
>>>>> traceback on CTRL-C.
>>>>>
>>>>> The string function upper() has been deprecated in favor of string
>>>>> methods. Used upper() method instead.
>>>>>
>>>>> Also applied method strip() to strip leading and trailing spaces
>>>>> from input.
>>>>> William
>>>>> _______________________________________________
>>>>> caiman-discuss mailing list
>>>>> caiman-discuss at opensolaris.org
>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
