Clay Baenziger wrote:
>         This code review request is for bug 1286 (the language selection
> prompt fails with a bash error if the user types a non-numeric answer).
> This is a one line fix.
>         Webrev: http://cr.opensolaris.org/~clayb/bug_1286/webrev1/

1. Erm... technically I'd suggest to use the script from
http://defect.opensolaris.org/bz/show_bug.cgi?id=1060 ('Alternative
script for language selction ("set_lang.ksh")') - I already did all the
hardeing for that one...
2. The script is still wrong. Please use the [[ ]] operator instead of [
] to avoid the extra expansion pass (or use [1]).

----

bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)

Reply via email to