Susan Sohn wrote:
> Please review the changes for:
>
> 6128 installadm reuses /var/ai data and screw up manifest
> http://defect.opensolaris.org/bz/show_bug.cgi?id=6128
>
> and
>
> 7122 installadm stop kills /usr/bin/dns-sd for all services of similar
> name
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7122
>
> which are posted at:
>
> http://cr.opensolaris.org/~sohn/6128_7122
>
> Thanks,
> Sue
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
installadm.c:
468: Can you add a comment on why normalize_service() is needed for
service_name?
708, 1019, 1119: Printing the service name along with txt record is better
862-867: Should change the status only if we can successfully stopped
the service. Move these lines after 878
installadm_util.c:
39: get_a_free_tcp_port() declared in this file and installadm.c (line
54). Can you move this declaration to installadm.h?
43: installadm_system() declared in this file and installadm.c (line
55). Can you move this declaration to installadm.h?
141: Can You could ombine these lines to one return statement such as:
return(read_service_data_file(path, data));
- Sundar
