Hi William,
Comments inline. New webrev at
http://cr.opensolaris.org/~clayb/6166/webrev2.
Thank you,
Clay
On Fri, 6 Mar 2009, William Schumann wrote:
> Clay,
> pkginfo.tmpl NAME= looks like a package name and it should be a short name
> for humans to read.
I agree. SUNWauto-install is:
NAME="SUNW-automated-installer"
But SUNWinstall (and most others) are much nicer with something like:
NAME="System install libraries and commands"
I've changed both SUNWauto-install and SUNWauto-install-common to be
better formed.
> I thought that new package names were not going to be prefaced with SUNW.
> Please check current policy on new package names.
I've pinged Dave and Sanjay for clarification and direction. I'm unaware
of any new policy, but that's likely just ignorance.
> Seeing publish_manifest.py in the review with Makefiles makes me wonder if we
> should start using symbolic references to common pathnames in Python.
> Consider making a Python constant with the same name as in Makefile.master:
> ROOTAUTOINST= $(ROOT)/usr/share/auto_install
I'm thinking you want what has been talked about as bug 4402 - Pull fixed
strings in A/I server python code out to a separate module. Is that
correct?
> All new files: update copyright year. Doesn't hg nits report this?
It does, my apologies for not having run hg nits. I'm now hg nits clean.
> Please document the new package dependency chain in bugzilla - just a few
> lines to help visualize.
>
> William
>
> Clay Baenziger wrote:
>> Hi William,
>> Can you look at this webrev for 6166? I think it achieves what you were
>> hoping to do with a new SUNWauto-install-common. I've updated the files
>> which seemed affected and tested the server. I'm deferring 6280 until after
>> this release, as it'll be a lot of change I think.
>>
>> Webrev:
>> http://cr.opensolaris.org/~clayb/6166/webrev/
>> Bug:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6166
>>
>> Thank you,
>> Clay
>
