The automated installer is intermittently reporting that there is slice
customization in the manifest, but there there is no slice action.

In the install_log, slice information is reported and random characters are
appearing:
  slice action <random characters> size=<absurd>
  conversion failure
  failed to modify slice(s) specified in the manifest

Found uninitialized pointer when no slice information.  Only manifested 
in stripped, non-debug version.

The real fix here is 2 lines in auto_parse_manifest, setting slice 
information pointer to NULL if no slice info before returning.

also, in auto_parse.c: p = ai_get_manifest_values(AIM_SLICE_ACTION, &len)
checking returned slice info length as well as pointer to allocated memory.

Also did cleanup:
-moved string for RNG element ai_manifest/ai_auto_reboot to #define
-moved #defines for RNG elements to auto_install.h
-changed routine name get_manifest_element_value() to 
ai_get_manifest_element_value()

http://cr.opensolaris.org/~wmsch/bug-7219/
http://defect.opensolaris.org/bz/show_bug.cgi?id=7219

Checked on SPARC, x86 with non-debug auto-install with slice information 
and without slice information
checked that setting auto-reboot in the manifest still worked

Reply via email to