Hi Ethan.
Thanks for having a look, and thanks for catching that issue.
I have updated the webrev to return not-validated when NULL is passed in.
Thanks,
Jack
On 03/11/09 14:57, Ethan Quach wrote:
> Jack,
>
> installadm_util.c - What's returned if NULL is passed into
> validate_service_name()?
>
>
> -ethan
>
>
>
> Jack Schwartz wrote:
>> Hi everyone.
>>
>> Fix has been renovated with the following:
>> - Only alphanumeric chars, underscore and hyphen allowed in service
>> names, per our bugcourt meeting yesterday.
>> - I fixed that the service name wasn't checked everywhere necessary.
>> - Shortened several lines > 80 chars and other stuff like that to get
>> code hg nits clean.
>> - Other cleanup.
>>
>> Same location:
>> http://cr.opensolaris.org/~schwartz/090306.1/webrev/
>>
>> Please review.
>>
>> Thanks,
>> Jack
>>
>> On 03/06/09 13:41, Jack Schwartz wrote:
>>> Hi everyone.
>>>
>>> Here is a code review for a couple of small bugfixes:
>>>
>>> 5091 AI install does not work if your service name had . in it.
>>> 4610 most installadm commands need to err out gracefully if not root
>>>
>>> http://cr.opensolaris.org/~schwartz/090306.1/webrev/
>>>
>>> Please review.
>>>
>>> Thanks,
>>> Jack
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
