Eric J. Ray wrote: > > On Mar 11, 2009, at 4:46 PM, Glenn Lagasse wrote: > >> Hey Karen, >> >> * Karen Tung (Karen.Tung at Sun.COM) wrote: >> >> Thanks for the feedback! >> >> <SNIP> >> >>>> So, thoughts? >>>> >>>> Thanks! >>>> >>>> >>> Hi Glenn, >>> >>> Personally, I like the idea of having the code for generating the >>> checksums be part of same script that creates the images. Like you, >>> I see a strong link between the 2 activities. >>> >>> However, I don't like the pre-defined set of crypto algorithms. >>> I think we should allow ppl to choose which algorithms they want to >>> use. >>> >>> I like the idea of adding the following to the manifest >>> >>> <iso_checksums> >>> <cksum_type="md5"/> >>> <cksum type="sha1"/> >>> ... >>> </iso_checksums> >>> >>> Perhaps checksum generation will be off if that section is missing or >>> empty. If it is not empty, then, we generate checksum for all the >>> algorithm specified. This provides the most flexibility, and people >>> can pick and choose which checksum to generate, if any at all. >> >> I don't feel strongly one way or the other about this. On the one hand, >> a simple toggle (enable checksums) appeals to my 'keep things simple' >> mindset. Especially given that I believe the default set of checksum >> types I've envisioned is pretty complete (no one I know of generates >> hashes greater than sha256 for any media distribution) and doesn't >> impact construction time in any appreciable way. On the other >> hand, specifying which checksum types you want to generate appeals to my >> 'allow the user to dig as big a hole as he'd like' (as it were) >> mindset. >> >> Any one else have more thoughts on this? >> > > What's the design philosophy behind the OpenSolaris installer? Simple? > Dig a hole? Extensible? What's the 80% case? > I believe a good design should be one that's simple to use for the average user, and provide flexibility for the "advanced" user without causing confusion. This has been the guiding philosophy for the whole design of DC as All useful defaults are chosen for the manifest, so the new user can build their own image without too much trouble. For the advance user, they can customize to their heart's content with all the flexibility provided by the finalizer scripts.
--Karen
