Hi Clay, the changes look good. I have only nit - could you please add comment to the code explaining that there is a specific reason why XML comment sections are omitted from manifest ?
Thank you, Jan On 03/19/09 12:12, Clay Baenziger wrote: > Hello, > I have a low risk bug fix which affects SC manifests with > comments. In the "smushed" form where the SC manifest is in a comment > block a comment within the block will of course generate an error if > one tries to validate the XML, however, in the more admin friendly > form of having separate AI and SC manifests a comment in the SC > manifest will be passed in to the resultant file stored on the AI > webserver (a comment in a comment -- which isn't legal XML as far as I > know). > As such, I propose simply stripping comments out of the SC > manifest when they're read in for validation. This can be done with > this one line change. > I've tested this fix by trying it both with free-standing SC > manifests containing comments and those without. I've then repeated > the tests with embedded manifests. All results were the same, except > in the case of a free-standing SC manifest with a comment which had > the comment stripped out when placed in the server's AI_data directory. > > Webrev: > http://cr.opensolaris.org/~clayb/7503/webrev/ > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=7503 > > Thank you, > Clay > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
