Jack Schwartz wrote: > Hi Joe. > > I would prefer seeing changes for enabling ssh to go into the manifests > instead of into grub_setup.py. The entries in grub_setup.py are like > base reference entries. Others, such as accessibility entries, can be > based off of them. The ssh entry falls into the second category. > > Adding the changes to a manifest is easy. Under > <grub_menu_modifications> add the following: > > <entry> > <title_suffix>Enable SSH</title_suffix> > <line>kernel$ > /platform/i86pc/kernel/$ISADIR/unix -B livessh=enable</line> > <line>module /boot/boot_archive</line> > </entry>
Thanks for the explanation on how this works Jack! Will do. Joe > > Regarding changes to ict.py: > > I think what you are trying to do is to enable happy face boot for all > entries in the grub menu. (sed acts on all entries.) Is this correct? > If so, the comment between 964-954 is incorrect as it does it for all > entries. Yes you are correct. I've updated the comment. > > Also, comment 2 in the bug report for 7077 is a little misleading. It > doesn't look the same, although I think it is functionally equivalent. > am I correct? Yes, you are correct. It is functionally equivalent. > > Thanks, > Jack > > > > > On 03/20/09 04:44, Joseph J VLcek wrote: >> Hello Caiman-ites, >> >> OK, let's try this again shall we. This time with the pointer to the >> webrev! ;) >> >> (Thanks for pointing out it was missing Karen! ;) >> >> Could I please get a code review for the changes for bugs 6431 and 7077. >> >> Huge thanks! Joe >> >> Webrev: >> http://cr.opensolaris.org/~joev/bug6431_7077/ >> >> 6431 ssh or rlogin service should be enable in install image for >> automated testing >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=6431 >> >> >> 7077 ICT - remove GRUB entry "text boot >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=7077 >> >> Note regarding 6431: >> -------------------- >> This fix is for the GUI installer. The required changes for the AI >> installer will be tracked in bug 4443. See the bug for more info. >> >> Description of change for 7077: >> ------------------------------- >> >> The additional "text boot" GRUB menu entry went in to the gate at: >> >> changeset: 350:cbcc5f485007 >> user: Joseph J Vlcek <Joseph.Vlcek at Sun.COM> >> date: Thu Nov 13 22:13:04 2008 -0700 >> summary: 4673 Grub text only mode is required >> >> I reverted the section of the affected code to the way it looked in >> the previous rev. >> >> modules affected: >> ----------------- >> >> * Distro Construction (grub_setup.py) >> * LiveCD Image >> >> testing done: >> ------------- >> >> Using DC, I built an image with the updated grub_setup.py >> >> I then used lofiadm to add the updated live-fs-root and set_lang to >> the image. >> >> Booted the live image and confirmed: >> - A new "ssh enabled" GRUB entry is available. >> - ssh is enabled on the live desktop >> - the default language settings are made. >> >> To test the changes to ict.py for bug 7077: >> >> On the live desktop I used mount -F lofs... to introduce the updated >> ict.py file, performed a full GUI install and confirmed the "text >> boot" entry was no longer presented by GRUB. >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
