Hi Jack, the fix looks good.
I have only small nit - since after removing that code $SED is no longer used in installadm-common.sh, line 37 could be removed as well. No need for another round of code review :-) Thank you for taking care of this, Jan On 03/22/09 21:18, Jack Schwartz wrote: > Hi everyone. > > Please review this easy fix for removing remaining normalization code > from a function called during installadm create-service. > > Bugfix 5091 removed dots and spaces from names, so the code addressed > by this webrev is no longer needed. > > There was a question initially of whether or not the function this > code was in was dead code; it is not. The fix would have been > different if it was, so I needed to confirm before fixing the right way. > > Webrev: > http://cr.opensolaris.org/~schwartz/090322.1/webrev/index.html > > Bug report: > > > Thanks, > Jack > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
