Hi Jack, Thank you for the review. This is a good suggestion. However, rather than setting umask in do_create_service, I think it is better to set it in main, so it can be inherited by all of the subcommands, not just create-service.
I've implemented it that way - the webrev is updated. Thanks, Sue On 03/23/09 10:06, Jack Schwartz wrote: > HI Sue. > > The changes in the webrev will probably work, but am not sure this is > the best solution. > > My understanding is that setup-tftp-links.sh is the x86 equivalent to > setup-sparc.sh. Is this correct? > > I notice that umask doesn't get set in setup-tftp-links.sh. I'm curious > about this lack of symmetry. I see that setup-image has a call to umask. > > Might it be better to set the umask once in installadm > do_create_service(), for all architectures, rather than in multiple places? > > Thanks, > Jack > > On 03/23/09 09:24, Susan Sohn wrote: >> Please review the changes for: >> >> 7275/etc/netboot/wanboot.conf has wrong permissions >> http://defect.opensolaris.org/bz/show_bug.cgi?id=7275 >> >> which are posted at: >> >> http://cr.opensolaris.org/~sohn/7275 >> >> Thanks, >> Sue >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
