Could I please get a code review for the fixes for bugs 6744, 4407 & 7570.
Bugs: ----- 6744 beadm fails for sparc AI sun4v due to missing /rpool/boot/menu.lst http://defect.opensolaris.org/bz/show_bug.cgi?id=6744 4407 AI should also tranfer the ai_sd_log and the revelant xml to the system after install http://defect.opensolaris.org/bz/show_bug.cgi?id=4407 7570 boot -L does not work on sparc due to missing <rootpool>/platform/`uname -m`/bootlst http://defect.opensolaris.org/bz/show_bug.cgi?id=7570 Webrev: ------- http://cr.opensolaris.org/~joev/bug6744_4407_7570 Brief description: ------------------ The majority of the changes involve: Two new ICT added to ict.py: - create_sparc_grub_menu (fix for: bug6744) - copy_sparc_bootlst (fix for: bug7570) One updated ICT in ict.c - ict_transfer_logs (fix for bug 4407) I made some minor fixes to the ict_test.c test program. Some changes involve small cleanup and rearranging as needed for these changes. The modules affected and tested: -------------------------------- liborchestrator liblogsvc <- small change install-finish ICT, Library and Python Testing done on SPARC --------------------- 1. I manually set up an AI install environment on a SPARC system. I then used the ict_test program and the ict.py exerciser to invoke the relevant ICT. 2. I built a SPARC AI image to include my updated bits. Then a full AI install was performed. (Thank you Jan for the help with this.) 3. Testing done on x86 (to confirm no regressions:) - Booted LiveCD image in VirtualBox - using ld_preload to load updated libraries - mount -F lofs to mount updated ict.py - cp updated install-script to /sbin - performed install * Results: All ICT completed successfully and system booted Thank you! Joe
