jan damborsky wrote:
> Hi,
>
> could I please ask for reviewing changes for following bug ?
>
> 4443 Automated Installer needs support for better observability
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4443
>
> webrev:
> http://cr.opensolaris.org/~dambi/bug-4443
>
> Thank you very much,
> Jan
>
>
> summary of changes:
> -------------------
>
> * remote access via ssh is enabled if 'livessh' option is set to
> 'enable' in install configuration file (menu.lst or install.conf)
>
> * installer is run in debug verbose mode if 'install_debug' option
> is set to 'enable' in install configuration file (menu.lst or
> install.conf):
>
> - debug verbose level is set to the highest one (LS_DBGLVL_INFO) for
> liblogsvc
> logging service (affects TD, TI, orchestrator, transfer module, AI)
>
> - BE_PRINT_ERR=true
>
> - following pkg(1) subcommands are run in verbose mode ('-v' option
> is appended)
>
> - pkg install
> - pkg uninstall
> - pkg list
>
>
> modules affected:
> -----------------
> * transfer module
> * live-fs-root
> * AI (auto-installer SMF start method, auto-install)
>
> testing done:
> -------------
> [1] Distribution Constructor tested with modified transfer module
>
> [2] Sparc & x86 AI images built (based on 111)
> verified for both x86 & Sparc that
>
> * ssh access is available if 'livessh=enable' provided in
> install configuration file
>
> * logging service verbose level set to LS_DBGLVL_INFO
> if 'install_debug=enable' provided in install
> configuration file
>
> * pkg commands are run in verbose mode (with '-v' option)
> if 'install_debug=enable' provided in install
> configuration file
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Looks good Jan!
Thanks for doing this!
My comments below.
Joe
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/cmd/auto-install/auto_install.c
Issue 1:
--------
Missing "break; between lines 1582 and 1583
1581 case 'v': /* debug verbose mode enabled */
1582 enable_debug_mode(B_TRUE);
break;
1583 }
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/cmd/auto-install/svc/auto-installer
Looks OK
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/cmd/slim-install/svc/live-fs-root
Nit/suggestion: Move both the install.conf file name and file spec to
variables.
Perhaps change from:
48 INSTALL_CONF=/tmp/install.conf
To:
INSTALL_CONF_FILE="install.conf"
INSTALL_CONF_SPEC="/tmp/${INSTALL_CONF_FILE}"
Then you could:
From:
315 # download the install.conf file to get the service name
for SPARC
316 if [ "$ISA_INFO" = "sparc" ]; then
317 install_conf="$url/install.conf"
318 /usr/bin/wget $install_conf -O $INSTALL_CONF > \
and
373 AI_ENABLE_SSH=`/usr/bin/grep "^livessh"
$INSTALL_CONF |
To:
# download the install configuration file to get the
service name for SPARC
if [ "$ISA_INFO" = "sparc" ]; then
install_conf="$url/${INSTALL_CONF_FILE}"
/usr/bin/wget $install_conf -O $INSTALL_CONF_SPEC >\
and
AI_ENABLE_SSH=`/usr/bin/grep "^livessh"
$INSTALL_CONF_SPEC |
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/libict_pymod/ict.py
It's not clear to me why this needs to change.
Please explain?
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/libtransfer/transfer_defs.py
looks OK
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/libtransfer/transfer_mod.py
looks OK
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/libtransfer/transfermod.h
looks OK
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/libtransfer_pymod/libtransfer.c
looks OK
