Hi Ethan.
On 04/06/09 09:52, Ethan Quach wrote:
>
>
> Jack Schwartz wrote:
>> HI Ethan.
>>
>> Thanks for taking a look.
>>
>> On 04/05/09 21:04, Ethan Quach wrote:
>>> Hey Jack,
>>>
>>> Not a full review, but just a couple of nits
>>>
>>>
>>> Does this change the syntax for ranges in the criteria from
>>> 'None' to 'unbounded' ?
>> Yes, and I know I'll need to post a flagday about this when I push.
>>
> Thanks for clarifying.
>
>>>
>>> VerifyXML.py - 278-279 - are these two lines supposed to be
>>> commented out?
>> Yes. I thought it would give added context to the two comment lines
>> at the bottom of the file. It is a style thing, so I can do it
>> differently if it is important to you that I change it. Just let me
>> know.
>
> Well, it looks like it'd do nothing and pass through anyway, so I
> would prefer that the commented lines 278-279 get removed.
>
OK. I'll move the comment elsewhere and remove the commented code.
Thanks,
Jack
>
> thanks,
> -ethan
>
>>
>> Thanks,
>> Jack
>>>
>>>
>>> thanks,
>>> -ethan
>>>
>>>
>>> Jack Schwartz wrote:
>>>> Hi everyone.
>>>>
>>>> Here is a webrev of my proposed fixes for:
>>>> 4325 Better syntactic treatment of IP and MAC address AI criteria
>>>>
>>>> A medium-level description of the changes is in the bug-report:
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4325
>>>>
>>>> Webrev:
>>>> http://cr.opensolaris.org/~schwartz/090402.1/webrev/
>>>>
>>>> Testing done:
>>>>
>>>> Ran publish manifest and verified with webserver:
>>>> - MAC: min/unbounded, IP: unbounded/max, network: min/unbounded,
>>>> mem: single <value> for range, minMAC has single digit btwn
>>>> colons
>>>> - range with three values: correctly failed validation
>>>> - range with two unbounded values: correctly failed validation
>>>> - range with 0 minimum: correctly passed validation
>>>> - single IP addr given as a <range>: corectly failed validation
>>>> - pair of values given as a <value>: correctly failed validation
>>>> - 2 values for non range criterion, surrounded by <value>:
>>>> correctly failed validation
>>>> - single value for non range criterion, surrounded by <value>:
>>>> passed validation
>>>> - 2 values for non range criterion, surrounded by <range>:
>>>> correctly failed validation
>>>> - Try a combination with a non-numeric value (arch=sparc): worked
>>>> Also verified list-manifests displayed data correctly.
>>>>
>>>> I'm requesting that Clay review, as he's most familiar with the
>>>> code I've changed and he has a heads-up that it's coming. Others
>>>> are invited to review as well.
>>>>
>>>> Tomorrow I'll verify that an install starts as it should, but I
>>>> have confidence it will work as the webserver output looks fine.
>>>>
>>>> Sorry to rush. I'm requesting a review ASAP, by COB tomorrow if
>>>> possible. I'm supposed to be done on Friday, but to give less than
>>>> 1 day for this review is not really realistic.
>>>>
>>>> Thanks,
>>>> Jack
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
