Susan Sohn wrote:
> Please review the changes for:
>
> 7388 create-service not reusing port number on a disabled service
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7388
>
> which are posted at:
>
> http://cr.opensolaris.org/~sohn/7388
>
> Thanks,
> Sue
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
/usr/src/cmd/installadm/installadm_util.c
-----------------------------------------
Issue 1:
--------
The usage of MSG_GET_SMF_INSTANCE_FAILED on lines:
483 if (ai_get_instance(handle, "default") != AI_SUCCESS) {
484 (void) fprintf(stderr, MSG_GET_SMF_INSTANCE_FAILED,
485 service_name);
Does not match the definition in installadm.h
183 #define MSG_GET_SMF_INSTANCE_FAILED INSTALLADMSTR(\
184 "Failed to get the SMF instance.\n")
I think you need a %s in the definition and perhaps a slightly different
wording or don't pass service_name...
Issue 2:
--------
I think you may need to free ai_name before returning at line 486:
Change from:
486 return (B_FALSE);
Change to:
free(ai_name);
486 return (B_FALSE);
Joe
