Susan Sohn wrote:
>
> On 04/08/09 14:30, Evan Layton wrote:
>> Can I please get 2 reviewers for:
>>
>> 7148 installadm should give correct dhcp macro for the subnet
>> being configured on the server
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7148
>>
>> 7982 7218 appears to break get_service_address()
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7982
>>
>> Webrev is at:
>> http://cr.opensolaris.org/~evanl/7148,7982/
>>
>> These are pretty simple fixes. I've tested them by creating services
>> on a machine with more than one subnet and default router. I've also
>> used create-client to create macros for specific machines. I've been
>> able to do successful AI installs from these setups.
>>
>> Thanks!
>> -evan
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> Evan,
>
> Just some minor comments...
>
> setup-dhcp
> 311 - subnets check -> subnets. Check
Fixed.
> 335 - give full path for dhtadm
Fixed.
>
> installadm-common
> 349-352 - update comment ala smf
Ethan mentioned the same comment issue. Here's the new text.
# Search for the txt_record in the AI service's SMF properties.
# The data is stored as a property of the AI service's property group.
>
> Sue
I've updated the webrev with everyone's changes...
Thanks for the review comments!
-evan
