Hi Evan.
Thanks for your review.
Per our phone discussion, I have changed the comment in the Makefile to
read:
#
# Note that the names of the database items below must be in lower-case letters
# except for the MIN or MAX prefixes used in range names.
#
to make it clearer, and have updated the webrev accordingly.
Thanks,
Jack
On 04/16/09 14:08, Evan Layton wrote:
> Only one small nit. It may be clearer if the comments stated that the
> MIN and MAX names are used for ranges.
>
> Other than that it looks fine to me.
>
> -evan
>
> Jack Schwartz wrote:
>> Hi everyone.
>>
>> Please review a quick fix for:
>> 8231 Capitalized criteria names won't work
>>
>> http://cr.opensolaris.org/~schwartz/090416.1/webrev/
>>
>> Tested with all combinations of lower and upper case characters for
>> both range and value criteria.
>>
>> I also added a few comments clarifying database criteria name
>> assumptions.
>>
>> Thanks,
>> Jack
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
