Hi Ethan,

On Thu, 16 Apr 2009, Ethan Quach wrote:

> Alok,
>
> I don't think you have the latest pull of the gate ... DOCROOT is now VARAI

Thanks for pointing that out, I can see how I
might have overlooked that.

> setup-service.sh - 400 - nit - why not just set service_action to $1 ?
>
> 247-249 - Don't you want this chunk somewhere after 255, so that
> in case we're deleting a service that's disabled, i.e. not running.

Changed. Updated webrev at -

http://cr.opensolaris.org/~aalok/8198/

Thanks for the review,
Alok

Reply via email to