Hi Sundar,

thank you very much for review.
Please see my response in line.

The webrev has been updated accordingly.

Jan


On 04/21/09 02:48, Sundar Yamunachari wrote:
> Jan,
>
>     The changes look good but there are couple of nits.
> *
> usr/src/cmd/installadm/create-client.sh:*
>
> 45: Can you provide an example like 0100144FA2574C. For create-client, 
> user provides mac_address in the standard format like 0:14:4F:A2:57:4C

Done.

>
> *usr/src/cmd/slim-install/svc/live-fs-root:
>
> *315, 323: Can you check value of ai_image_dir and ai_server after 
> getting them from wanboot.conf to make sure that they are not null?*
> *

Done.

> *
> *317:  Can you also add a debug message to indicate that "The AI image 
> will be retrieved from $ai_image_dir"? It will be useful if the user 
> see the image directory if it is different from what is expected.

Done.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090421/3322a048/attachment.html>

Reply via email to