jan damborsky wrote:
> Hi,
>
> could I please ask two people for reviewing changes for following blocker ?
>
> 8262 'installadm create-service' shouldn't overwrite
> /etc/netboot/wanboot.conf for Sparc, but notify user instead
>
> webrev:
> http://cr.opensolaris.org/~dambi/bug-8262
>
> Thank you very much,
> Jan
>
>
> modules affected:
> -----------------
> * installadm tools (Sparc platform)
>
> testing done - please see attached test procedures
> ---------------------------------------------------
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hope this helps Jan.
usr/src/cmd/installadm/setup-service.sh
---------------------------------------
281 [ ! -f "${WANBOOT_CONF_SPEC}" ] && \
282 /usr/bin/rm -f "${WANBOOT_CONF_SPEC}"
Am I reading this wrong or is it not correct?
If "NOT" file "${WANBOOT_CONF_SPEC}" then delete it?
usr/src/cmd/installadm/setup-sparc.sh
--------------------------------------
#1:
---
57 installconf="${image_path}/${SPARC_INSTALL_CONF}"
Is this SPARC specific code? If so please describe that in the function
comment. If not why prepend SPARC_ to INSTALL_CONF ?
#2:
---
107 [ ! -d "$confdir" ] && /usr/bin/mkdir -p "$confdir"
Consider setting the directory mode with the -m flag to mkdir.
#3:
---
Question/Nit?
Does it make sense to put the entire functionality in the block of code
between lines 201 and 254 into it's own function or even incorporate it
into function create_wanbootconf?
#4:
---
One too many "image_directory="
230 image_directory=`/usr/bin/dirname
"$root_file_location"`
231 image_directory=`/usr/bin/dirname
"$image_directory"`
#5:
---
Wording suggestion and Sparc should be all caps SPARC
238 echo "Service $srv_dfl is currently used by Sparc" \
239 "clients not explicitly associated with other" \
240 "service by 'create-client' subcommand"
To:
echo "Service $srv_dfl is currently used by SPARC" \
"clients not explicitly associated with another" \
"service by the use of the 'create-client' subcommand"
#6:
---
Wording suggestion and Sparc should be all caps SPARC
242 echo "Another service is currently used by Sparc" \
243 "clients not explicitly associated with other" \
244 "service by 'create-client' subcommand"
To:
echo "Another service is currently in use by SPARC \
"clients not explicitly associated with a" \
"client specific service."
#7:
---
Wording suggestion and Sparc should be all caps SPARC
247 echo "Symbolic link has to be created in following way to" \
248 "select $svc_name service for those Sparc clients"
echo "To select service $svc_name for those SPARC clients" \
"use the following commands:"
