Hi Jack, the changes look good. I might have only nit - I am thinking if it might be better to slightly change the meaning of error message at lines 137-138. Something like
"Too many SMF network/physical services are not disabled." -> "Only one instance of SMF network/physical service can be enabled at a time." This is just a suggestion - the decision is up to you. No need for another round of code review. Thank you, Jan Jack Schwartz wrote: > Hi everyone. > > Please review the fix for blocker: > 8346 AI should work with NWAM > > This fix is basically the design I posted last Friday, but with better > svc checks. The bug report is current, and the comment in the file > should explain the code changes. > > http://cr.opensolaris.org/~schwartz/090427.1/webrev/ > > Tested by enabling and disabling the different combinations of > svc:network/physical:nwam and svc:network/physical:default > and seeing if installadm starts and/or the appropriate messages are > displayed. > > I would like Sundar and one other person to review please. > > Thanks, > Jack > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
